Skip to content

Conversation

@niktayv
Copy link
Collaborator

@niktayv niktayv commented Sep 3, 2025

What this PR does

Similar to TerriaJS/TerriaMap#764, I just added a minimal amount of ESLint rules and annotations to stop the build scripts from screaming with red squiggly lines.

Test me

No logic should have been changed; only the behaviour in VS Code is affected.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@niktayv niktayv force-pushed the tame-build-scripts-eslint branch from ebd105d to 3a2975f Compare September 3, 2025 08:08
@niktayv niktayv changed the title fix: tame ESiInt in build scripts Tame ESiInt in build scripts Sep 3, 2025
Copy link
Collaborator

@na9da na9da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @niktayv - thanks for the fixes. I have suggested one change to the regex.

na9da
na9da previously requested changes Oct 7, 2025
Copy link
Collaborator

@na9da na9da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @niktayv.

@na9da na9da dismissed their stale review October 7, 2025 03:39

Approved

Copy link
Collaborator

@na9da na9da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@na9da na9da merged commit f9354c6 into main Oct 7, 2025
9 checks passed
@na9da na9da deleted the tame-build-scripts-eslint branch October 7, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants