Update ExportData.tsx #7646
Open
Update ExportData.tsx #7646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i18n a fixed value
|
|
zoran995
requested changes
Jun 20, 2025
| <div className={Styles.metadata}> | ||
| <button onClick={this.exportDataClicked.bind(this, catalogItem)}> | ||
| Export data | ||
| {this.props.t("workbench.exportData")} |
Collaborator
There was a problem hiding this comment.
It would be better to create a new translation key e.g. description.exportData or preview.exportData to better reason on where it is used. Also, the value of this translation key is Export, and the expected string in the UI is Export data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i18n a fixed value
Test me
Go to dataset preview page and ensure "Export data" changes with each language
Checklist
doc/. (No relevant documentation)