gulpfile: throw right exception #7539
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoist the multiple imports of plugin-error to a single top level import. Also remove the "showStack: false" configuration to each call since that has been the default for ~10 years, break up the long string to fit in a line, and remove the questionmark at the end of the error message.
Throw a PluginError exception instead of the previous Error exception. The previous code had the wrong number of arguments for the constructor, so that did not work as intended.
pjonsson
force-pushed
the
gulpfile-right-exception
branch
from
11c8631 to
9c73924
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Throw a PluginError exception
instead of the previous Error
exception.
The previous code had the wrong
number of arguments for the
constructor, so that did not
work as intended.
Also hoist the imports to the top
level, break a long string into
multiple lines, and remove
the showStack argument which
already had the default value for
the past ~10 years.
Test me
Trigger the error and see that the exception is the expected one.
Checklist
doc/.