-
Notifications
You must be signed in to change notification settings - Fork 393
Fix 7296 wmts #7371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix 7296 wmts #7371
Conversation
| : [layer.ResourceURL]; | ||
|
|
||
| if (resourceUrls && (this.requestEncoding === "RESTful" || !url)) { | ||
| for (let i = 0; i < resourceUrls.length; i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could for (const resourceUrl of resourceUrls) { be used to iterate over the content so the next line can be omitted, or is there some JavaScript-reason to always use index-based iterations in TypeScript?
Same comment for the other for-loops where the index is only used to get the element.
eeaecab to
8a8b5a0
Compare
|
<Edit: sorry I didn't realise this was an unreleased branch that potentially fixes the below behaviour, I will wait for the final push and retest when released>. I'm not sure if this is related, or whether this is an adjacent issue, however when I add the NZ LINZ WMTS data (via https://data.linz.govt.nz/services;key=_removed_/wmts/1.0.0/WMTSCapabilities.xml) and add a layer, I don't see the tile data, instead a lot of After some investigation, the issue appears to be URL Encoding of the TileMatrixSet URL parameter. See below (noting EPSG%3A3857 vs EPSG:3857) Terria does this (and doesn't work): https://tiles-cdn.koordinates.com/services;key=_removed_/tiles/v4/layer=50767,style%3Dauto/EPSG%3A3857/9/497/327.png |
|
Hi @moosepants, I just tried loading that dataset using the CI deployment http://ci.terria.io/fix-7296-wmts, but it is still throwing an error due to the encoded tilematrix set value. We are requesting data as |
8a8b5a0 to
511650d
Compare
|
I've done some thorough testing both in the local environment and with the CI link. Currently, on the |
|
I also submitted a ticket to Koordinates about the URL-Encoded TileMatrixSet issue, asking them either to adjust their backend or provide an alias so that Cesium could use the ResourceURL without tweaking. |
|
Would love to see this merged -- this would fix my issues as well |
na9da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @zoran995 - the spec is breaking for invalid tilematrix because previously we defaulted to googlemapscompatible. Should we keep the default?
|
@na9da, I'm not confident we should define a default tile matrix. WMTS capabilities should advertise all supported CRS/tile matrices, and if we set a default, we’ll likely end up sending requests with a tile matrix that's highly unlikely to work. |
What this PR does
Fixes #7296, #2927, #1573
Extended OWS common interfaces lists and added support for reading the URL from operations metadata.
Test me
Try adding data using the init file https://gist.githubusercontent.com/zoran995/10169b47c7c7191f4795b56878c3d9c4/raw/2a27e2165b43f3e920dbebd181d4f6bd14ae4f4a/terriajs-7296-config.json
I have also tested using New Zealand LINZ data service mentioned in #2927
Checklist
doc/.