Skip to content

Conversation

@glughi
Copy link
Contributor

@glughi glughi commented Aug 29, 2024

What this PR does

Fixes TerriaJS/TerriaMap#690

Use appName from config.json to set the title of the web page.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@na9da
Copy link
Collaborator

na9da commented Oct 21, 2024

Hi @glughi,

Thanks for your PR.
For various reasons, it is best to set the application title from terriamap instead of from the Terria instance (for eg, Terria could be instantiated from a non-browser context like nodejs. We also don't assume a page to have just a single instance of Terria).

I have created a PR in terriamap to do this. Let me know if it'll work for you - TerriaJS/TerriaMap#700
Thanks.

@glughi
Copy link
Contributor Author

glughi commented Oct 21, 2024

Yes, it works!

@glughi glughi closed this Oct 23, 2024
@glughi glughi deleted the use-appName-for-document-title branch October 23, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

appName in parameters config dosen't work

2 participants