tsconfig: extend from node_modules #731
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #729
There is no "terriajs" directory
in this repository, so import
tsconfig.json from the terriajs
directory inside node_modules
instead, just like the ESLint
configuration does.
This requires re-defining outDir,
typeRoots, and include to the same
values that they have in terriajs,
since they will otherwise be relative
to the node_modules tsconfig.json.
The types option requires including
a couple of lib/ThirdParty directories
in terriajs.
The maxNodeModuleJsDepth parameter
is required for not getting errors
about implicit any types on jsx
imports in terriajs source code.