forked from dagster-io/dagster
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teradata initial commit #2
Open
tallamohan
wants to merge
17
commits into
master
Choose a base branch
from
teradata-initial-commit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an/dagster into teradata-initial-commit
Teradata initial commit
[like] Chinthanippu, Satish reacted to your message:
…________________________________
From: Mohan Talla ***@***.***>
Sent: Tuesday, December 3, 2024 5:28:17 AM
To: Teradata/dagster ***@***.***>
Cc: Chinthanippu, Satish ***@***.***>; Review requested ***@***.***>
Subject: [EXTERNAL] [Teradata/dagster] Teradata initial commit (PR #2)
[CAUTION: External Email]
Added TeradataResource and TeradataComputeClusterManager
________________________________
You can view, comment on, or merge this pull request online at:
#2
Commit Summary
* cab64eb<cab64eb> initial_commit
* 7235731<7235731> Added test case
* d2de755<d2de755> Create integration.yaml
* a7587a2<a7587a2> Merge branch 'dagster-io:master' into teradata-initial-commit
* 74e78c0<74e78c0> next commit
* 9c8cef1<9c8cef1> Merge branch 'teradata-initial-commit' of https://github.com/tallamohan/dagster into teradata-initial-commit
* 05bcb63<05bcb63> Added S3 and Azure
* b1645ad<b1645ad> added mandatory function get_object_to_set_on_execution_context
* 4c525f8<4c525f8> compute cluster create and drop
* 64bd8c9<64bd8c9> Removed sensitive data from config
* a5dfde4<a5dfde4> Added create and drop compute cluster
* 03cf182<03cf182> Removed hard coded values
* fc68012<fc68012> Merge pull request #1 from tallamohan/teradata-initial-commit
* fd1c118<fd1c118> refactored code
* 8ef30e3<8ef30e3> Added handle_cc_status and constants
* 2e32773<2e32773> added TeradataComputeClusterManager
File Changes
(23 files<https://github.com/Teradata/dagster/pull/2/files>)
* A python_modules/libraries/dagster-teradata/.coveragerc<https://github.com/Teradata/dagster/pull/2/files#diff-c6a41ecef58047409fa3c2f342ebd9bc2c8e7a2c86e06c84e7e42a64d2cd7c80> (2)
* A python_modules/libraries/dagster-teradata/LICENSE<https://github.com/Teradata/dagster/pull/2/files#diff-0bcc14a7233eb9368ef6c30494f59bc26b11e6c8c5d80c3b7e7594bed1566355> (201)
* A python_modules/libraries/dagster-teradata/MANIFEST.in<https://github.com/Teradata/dagster/pull/2/files#diff-e9fd57d80fa6b72cb33e625bf1e5deb88cb4651172d8b14112c4731d045dbd4e> (2)
* A python_modules/libraries/dagster-teradata/README.md<https://github.com/Teradata/dagster/pull/2/files#diff-e008d27b6a821f28ca5a8e1d309dc5f37c170cd487a44e1d7cd373ed843c40fb> (4)
* A python_modules/libraries/dagster-teradata/dagster_teradata/__init__.py<https://github.com/Teradata/dagster/pull/2/files#diff-ec346929f4f4ef3bb7d0ff25196a77b0e1187d9aecccd3cf21d8018b4e9ea953> (11)
* A python_modules/libraries/dagster-teradata/dagster_teradata/constants.py<https://github.com/Teradata/dagster/pull/2/files#diff-564c9fd641347e9aacfe3b6ed6f4d28cfbe454d164bdfb4a5692e0a78991061e> (29)
* A python_modules/libraries/dagster-teradata/dagster_teradata/py.typed<https://github.com/Teradata/dagster/pull/2/files#diff-7a207b871d1a560326cc8ae731128f76f640e5fd16b27d5889c4c45e5f3ca9f6> (1)
* A python_modules/libraries/dagster-teradata/dagster_teradata/resources.py<https://github.com/Teradata/dagster/pull/2/files#diff-896081ec11d086441abc62ba4fdbdf9926368fd009bce3c7bf353256f7c957d9> (464)
* A python_modules/libraries/dagster-teradata/dagster_teradata/teradata_compute_cluster_manager.py<https://github.com/Teradata/dagster/pull/2/files#diff-9b9cd6deb9aa1fd8211f1779445cbbec52f4a7005892302471aedcbccc5910a2> (350)
* A python_modules/libraries/dagster-teradata/dagster_teradata/teradata_io_manager.py<https://github.com/Teradata/dagster/pull/2/files#diff-2d790ebb47e47fc2edd40384db801e5550695be9c180c561163c19061e1d3a27> (135)
* A python_modules/libraries/dagster-teradata/dagster_teradata/version.py<https://github.com/Teradata/dagster/pull/2/files#diff-8e3a013d2ac742bf5db80a63e01acbf082c97fd7015d153a393a9e4e3166243b> (1)
* A python_modules/libraries/dagster-teradata/dagster_teradata_tests/__init__.py<https://github.com/Teradata/dagster/pull/2/files#diff-9393153b8a1811627a81f1d179a950b29e5ebfe2d1d14cc7231f30b48705c103> (0)
* A python_modules/libraries/dagster-teradata/dagster_teradata_tests/test_create_teradata_compute_cluster.py<https://github.com/Teradata/dagster/pull/2/files#diff-42315e0c5a6b0c03a78e455c5a2efa359ab4ff68eac9bc6c10db675d724ec37e> (50)
* A python_modules/libraries/dagster-teradata/dagster_teradata_tests/test_drop_teradata_compute_cluster.py<https://github.com/Teradata/dagster/pull/2/files#diff-271d3b12441621b6409e4ca012ec7f08032e684edeba71c6cee705646777ecda> (41)
* A python_modules/libraries/dagster-teradata/dagster_teradata_tests/test_io_manager.py<https://github.com/Teradata/dagster/pull/2/files#diff-13f649231492ccb015298495c26ac3d2a570956f5d5c33fd8e236fa392251736> (167)
* A python_modules/libraries/dagster-teradata/dagster_teradata_tests/test_resources.py<https://github.com/Teradata/dagster/pull/2/files#diff-10f91b265ff5be78c7613646ff8d25d4fea3b453f626427ee24c64f2657258bc> (107)
* A python_modules/libraries/dagster-teradata/dagster_teradata_tests/test_s3_to_teradata_S3Resource.py<https://github.com/Teradata/dagster/pull/2/files#diff-57b6d1c82362140c76dc4f59ac1ef2679bf0bb727c4d2bebe4274e54fbb34876> (34)
* A python_modules/libraries/dagster-teradata/dagster_teradata_tests/test_s3_to_teradata_session.py<https://github.com/Teradata/dagster/pull/2/files#diff-d6ad0bdc049d98ca3c39b0f434082abd2366401a328bd1f95d2746e6aaba70ea> (35)
* A python_modules/libraries/dagster-teradata/integration.yaml<https://github.com/Teradata/dagster/pull/2/files#diff-c1e7319300736ec3cf5ab9c4124adfa38d930c8c94787b41ef27746865ae63e1> (5)
* A python_modules/libraries/dagster-teradata/setup.cfg<https://github.com/Teradata/dagster/pull/2/files#diff-875bc565097dc6deb1f4c6494a99896879392d218e0a32ff1798b29abadaa55a> (7)
* A python_modules/libraries/dagster-teradata/setup.py<https://github.com/Teradata/dagster/pull/2/files#diff-3310f7efa62ba362c4007b8b9b6880f89b36e81bb766cd47ac6133b8a109582b> (44)
* A python_modules/libraries/dagster-teradata/tox.ini<https://github.com/Teradata/dagster/pull/2/files#diff-e242a8eb8b3e351694d186ce0636a1ad318a8d310c4ab6c3556e77489d6b10c7> (22)
* M scripts/install_dev_python_modules.py<https://github.com/Teradata/dagster/pull/2/files#diff-85c2bb6d4721ed0a146ea51e2bd615dbdf2249ad3714adc1cacc1877707cadee> (1)
Patch Links:
* https://github.com/Teradata/dagster/pull/2.patch
* https://github.com/Teradata/dagster/pull/2.diff
—
Reply to this email directly, view it on GitHub<#2>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFPW3AUV57XG7GSR5S722TT2DU6PDAVCNFSM6AAAAABS46U7L6VHI2DSMVQWIX3LMV43ASLTON2WKOZSG4YTIMBTGU4DQNQ>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
sc250072
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments and questions
python_modules/libraries/dagster-teradata/dagster_teradata/resources.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-teradata/dagster_teradata/resources.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-teradata/dagster_teradata/teradata_io_manager.py
Outdated
Show resolved
Hide resolved
sc250072
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added TeradataResource and TeradataComputeClusterManager