Added code to update grafana dashboards on monitoring-integration start #576
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,15 +30,21 @@ def upload_default_dashboards(): | |
| datasource.create() | ||
| dashboards = dashboard_utils.get_all_dashboards() | ||
| for dashboard_json in dashboards: | ||
| dashboard = dashboard_json["uri"].split('/')[1] | ||
| title.append(dashboard) | ||
| # Deleting already existing dashboards if present | ||
| response = dashboard_utils.delete_dashboard(dashboard) | ||
|
There was a problem hiding this comment. We don't want to delete all dashboards in every sync. I think we need to find a better way of handling this situation. We need to see if there is an intersection/difference between the two files then only we need to update it. Otherwise, the will keep refreshing the dashboards and can cause a problem(while a user is at a particular dashboard) also it increases the number of calls on the server. There was a problem hiding this comment. @cloudbehl agreed, will see to it. |
||
| if 'title' in response: | ||
| msg = "\n Already existing %s deleted. \n" % dashboard | ||
| logger.log("debug", NS.get("publisher_id", None), | ||
| {'message': msg}) | ||
| else: | ||
| msg = "\n%s delete failed with error: %s \n" % (dashboard, | ||
| str(response)) | ||
| logger.log("debug", NS.get("publisher_id", None), | ||
| {'message': msg}) | ||
|
|
||
| for dashboard_json in NS.config.data["dashboards"]: | ||
| response = dashboard_utils.create_dashboard(dashboard_json) | ||
|
|
||
| if response.status_code == 200: | ||
|
|
||
Empty file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This if condition is checking two completely different things:
["cluster-dashboard", "brick-dashboard", "host-dashboard", "volume-dashboard"] &
['tendrl-gluster-at-a-glance', 'tendrl-gluster-hosts', 'tendrl-gluster-volumes', 'tendrl-gluster-bricks']
But its not failing as we are going down straight to creating the dashboard again. The dashboards cannot get updated as the grafana rejects the request with : {u'status': u'name-exists', u'message': u'A dashboard with the same name already exists'} .