fix: restore support for Bazel 7 #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows rules_doxygen to support bazel 7.0.0 [ closes #22 ]
There was a problem hiding this comment.
Pull Request Overview
This PR restores support for Bazel 7 by removing the dependency on @bazel_tools and eliminating unnecessary code while extending CI tests for both Bazel 7.0.0 and 8.0.0. Key changes include:
- Providing clear guidance in README regarding the unavailable string_keyed_label_dict attribute in Bazel 7.
- Updating documentation in docs/extensions_doc.md to reflect new parameters and behavior.
- Updating the CHANGELOG to document the fixes and enhancements.
- Extending the CI pipeline (.github/workflows/ci.yml) with a new matrix configuration for multiple Bazel versions and injecting the .bazelversion file accordingly.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/substitutions/README.md | Added an IMPORTANT note to document Bazel 7 limitations |
| docs/extensions_doc.md | Updated function documentation and parameter details for clarity |
| CHANGELOG.md | Updated changelog entries to document the dependency removal and CI tests |
| .github/workflows/ci.yml | Added Bazel version matrix and steps to handle .bazelversion file creation |
Files not reviewed (1)
- extensions.bzl: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bazel_tools//tools/build_defs/repoto support Bazel 7.0.0 [ closes Starlark file @@bazel_tools//tools/build_defs/repo:cache.bzl is not visible for loading from package@@rules_doxygen~//... #22 ] (thanks to @filmil)get_auth