feat(form): The Readonly attribute of Form is added for the form read-only function #4176
+192
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaojueshi
requested review from
PengYYYYY,
chaishi,
xiaosansiji,
honkinglin,
LeeJim and
uyarn
as code owners
|
|
input 组件的 readonly 属性更改为使用 useFormReadonly 函数获取,以适配 Form 组件的 readonly 属性
修改 readonly 属性值的获取方式,以适配 Form 组件的 readonly 属性
uyarn
changed the title
|
我录个form readonly的API到API平台 |
uyarn
changed the title
uyarn
reviewed
May 8, 2024
src/hooks/useReadonly.ts
Outdated
| const formReadonly = inject<FormReadonlyProvider>('formReadonly', Object.create(null)); | ||
|
|
||
| return computed(() => { | ||
| if (isBoolean(context?.beforeReadonly.value)) return context.beforeReadonly.value; |
There was a problem hiding this comment.
这个你得听我狡辩一下，我在做的时候认为这个 readonly 应该与 disabled 的功能相似，只是样式有差别，so 我就直接参照着 useDisabled 写的
There was a problem hiding this comment.
@uyarn 这样有问题吗，guys？
There was a problem hiding this comment.
我感觉还是有需要再补充逻辑好点，每个PR就解决具体的问题或者新增当前需要的功能就好
xiaojueshi
changed the title
uyarn
reviewed
May 14, 2024
src/checkbox/checkbox.tsx
Outdated
| // Checkbox.readonly > CheckboxGroup.readonly > Form.readonly | ||
| const beforeReadonly = computed(() => { | ||
| if (!props.checkAll && !tChecked.value && checkboxGroupData?.value.maxExceeded) { | ||
| return true; |
There was a problem hiding this comment.
这个原来disabled的逻辑还是不用存在，这个逻辑是一个非全选的checkbox选项，且未选中且已经超出checkboxgroup配置的最大值的时候，不用管它是不是配置了disabled都要设置为disabled，不适用于readonly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(form): the Readonly attribute of Form is added for the form read-only function
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
feat(form): The Readonly attribute of Form is added for the form read-only function
feat(input): Compatible with readonly attribute of form component
feat(chekout): Compatible with readonly attribute of form component
feat(chekoutGroup): Compatible with readonly attribute of form component
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单