fix(date-picker): 修复在指定format和valueType下，年份解析错误问题 #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e week can't be included
Ericleungs
requested review from
PengYYYYY,
chaishi,
xiaosansiji,
honkinglin,
LeeJim and
uyarn
as code owners
|
|
|
是的valueType和format会造成一些歧义 但是目前暂时只能通过增加更多文档说明解决了 |
uyarn
requested changes
May 2, 2024
好的，我处理一下 |
Ericleungs
changed the title
…Picker & dateRangePicker
uyarn
approved these changes
May 20, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
感觉得需要在文档中说清楚一些，valueType和format，在我的理解里头format用于展示用的，只用于最后将数据展示给用户的时候的格式转换；valueType是用于解析date-picker中的实际的value，用于实际处理计算的。
或许需要重新捋清楚这俩属性的定义以及实际使用，和common库中的formatDate的参数在名称上好像没对齐。
📝 更新日志
fix(date-picker): 修复在指定format和valueType下，年份解析错误问题
fix(date-picker): 修复解析日期解析错误，导致周显示异常问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单