Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): fix false triggering create callback after pressing the enter key #4088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

okxiaoliang4
Copy link

@okxiaoliang4 okxiaoliang4 commented Apr 9, 2024

修复当筛选时回车触发了handleCreate之后将inputValue清空导致显示了全部option然后再选中了全部option中hover下标的数据

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(Select): 修复过滤状态下按下回车键误触发create回调的异常问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Apr 9, 2024

完成

@uyarn uyarn changed the title fix: 修复当筛选时回车触发了handleCreate之后将inputValue清空导致显示了全部option然后再选中了全部option中hover下标的数据 fix(Select): fix false triggering create callback after pressing the enter key Apr 9, 2024
@uyarn
Copy link
Collaborator

uyarn commented Apr 9, 2024

这个改动会影响组件正常的行为 单选状态下如果不是开启reserveKeyword 选中后是会清空keyword展示全部选项的;
但是组件现在的handleCreate事件也不纯粹 包含了清空keyword的内容

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants