Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): radio选中当前项时,不再重复触发change #3527

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ziyi99
Copy link
Contributor

@ziyi99 ziyi99 commented Oct 26, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(组件名称): 重复点击当前已选中radio不再触发change事件

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

失败

@ziyi99
Copy link
Contributor Author

ziyi99 commented Oct 31, 2023

test代码要求radio必须change一次,但此PR修改内容为:radio选中状态下,重复点击不再重复触发change。 此更改与测试代码冲突,elementUI中,radio为true状态下的重复点击不会再触发change,直觉上来说,change是选中项更改后才触发。 对于是否需要做出此修改,还需等待管理员评估

@PengYYYYY
Copy link
Collaborator

修改一下单测

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants