fix: input 输入框添加clearable属性并输入内容，hover时宽度进行变化 #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaishi
reviewed
Jun 25, 2023
| opacity: 1; | ||
| visibility: visible; | ||
| } | ||
|
|
There was a problem hiding this comment.
这个 common 因为涉及到 Vue2/Vue3/React 多个框架，所以变更需谨慎。
看了下当前的变更，存在 Breaking Change，会影响 Vue2/React。有种选择：
- 选择一：基于当前的 CSS 内容实现效果
- 选择二：实在要调整 CSS，是否可以兼容变更
- 选择三：实在要调整 CSS，且一定存在不兼容变更(BreakingChange)，则需要 3 个框架一起提 PR
There was a problem hiding this comment.
选择二。发现react版本也存在此问题，故修改了公共样式，初步测了一下，可以兼容此变更。react故障演示如下：https://codesandbox.io/s/tdesign-react-demo-7ytwwz?file=/src/main.jsx
blank-peas
force-pushed
the
fix/input组件clearable属性,hover时宽变化
branch
from
909dbc5
to
7f58649
Compare
chaishi
reviewed
Jun 26, 2023
style/web/components/form/_var.less
Outdated
| @@ -50,3 +50,6 @@ | |||
| @input-box-shadow-color-warning-focus: @warning-color-focus; | |||
| @input-border-color-error: @error-color; | |||
| @input-box-shadow-color-error-focus: @error-color-focus; | |||
|
|
|||
| // inline | |||
| @form-inline-content-width: 200px; | |||
blank-peas
force-pushed
the
fix/input组件clearable属性,hover时宽变化
branch
from
7f58649
to
f695f9d
Compare
|
tdesign-vue preview 地址：（如果你有 DOM 变动请自行在对应技术栈仓库中发起 PR） |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
#3001
💡 需求背景和解决方案
修复前：
修复后：
📝 更新日志
fix(input): input 输入框添加clearable属性并输入内容，hover时宽度进行变化
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单