Skin Tool with index, onboarding and first advanced tools #2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 22 out of 27 changed files in this pull request and generated 1 comment.
Files not reviewed (5)
- package.json: Language not supported
- src/pages/skin-tool/advanced-tools.css: Language not supported
- src/pages/skin-tool/fonts/fonts.css: Language not supported
- src/pages/skin-tool/onboarding/create-color.css: Language not supported
- src/pages/skin-tool/onboarding/create-typo.css: Language not supported
Comments suppressed due to low confidence (2)
src/pages/skin-tool/utils/storageUtils.js:86
- [nitpick] Clarify the comment regarding whether the final skin configuration should include the full palette or a subset of colors to avoid confusion.
// Should return the rest of color variables or only the ones skin tool lets you choose?
src/pages/skin-tool/onboarding/create-border.jsx:113
- Ensure that getInitialBorderIndex correctly handles cases where savedRadius is not found (findIndex returns -1) instead of defaulting to 0 via logical OR.
const getInitialBorderIndex = () => { const savedRadius = borderConfig.radius; return borderRadiusValues.findIndex(value => value === savedRadius) || 0; };
| // Function to reset all the colors to their initial empty state | ||
| const handleResetColors = () => { | ||
| setColors(initialColors); | ||
| localStorage.setItem('userColors', JSON.stringify(initialColors)); |
There was a problem hiding this comment.
The reset function is using the key 'userColors' while the rest of the code uses 'skinColors'. Update the key to 'skinColors' for consistency.
Suggested change
| localStorage.setItem('userColors', JSON.stringify(initialColors)); | |
| localStorage.setItem('skinColors', JSON.stringify(initialColors)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version of the SkinTool, an intuitive tool for creating and previewing custom brand skins efficiently using Mística.