Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some smaller improvements on error logs/exceptions, ignores, file-checks, ... #139

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Some smaller improvements on error logs/exceptions, ignores, file-checks, ... #139

wants to merge 3 commits into from

Conversation

centic9
Copy link
Contributor

@centic9 centic9 commented Jan 27, 2015

A number of smaller adjustments:

  • Add a .gitignore to ignore some of the files/directories created by grails applications
  • Add some checks for things that we saw while starting to use Ice
  • The null-check in Config.java is too late currently
  • We saw some zero-length files in some cases, e.g. when the disk ran out of space before and you freed up space, Ice still wouldn't re-download the files

@centic9
Improve/Add some error messages that we found useful when starting to…
fbb7702 
… use Ice, one null-check is too late in Config, and check for file.length()>0 as we had cases where zero-length files caused the product to fail
@centic9
Add .gitignore with a useful ignores for grails applications
2b32083
@cloudbees-pull-request-builder
Copy link

ice-pull-requests #61 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder
Copy link

ice-pull-requests #62 SUCCESS
This pull request looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@centic9 @cloudbees-pull-request-builder