Use correct TBA key for backup robots #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBA expects keys like "1234B" for backup robots, and has no way to distinguish that "9234" is the backup bot for "1234" aside from being manually told. Use the approriate team key when pushing to TBA.
|
We should make sure this plays well with the TBA trusted API before this is merged. |
|
I emailed @gregmarra asking about that but have not heard back. I did spin up a local test instance of TBA and pointed Cheesy-arena at that and it worked fine, showing the backup teams properly. |
|
Actually, this will need the-blue-alliance/the-blue-alliance#1638 |
|
This should make use of #56 once it gets implemented. |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBA expects keys like "1234B" for backup robots, and has no way to
distinguish that "9234" is the backup bot for "1234" aside from being
manually told. Use the approriate team key when pushing to TBA.