Skip to content

Commit

Permalink
klte-common: force default backend for voice/voip calls
Browse files Browse the repository at this point in the history 
Change-Id: I49a196cee86bef4709663d731815f0b9994bf278
  • Loading branch information
@deVorteX @Albinoman887
deVorteX authored and Albinoman887 committed Feb 9, 2015
1 parent e614793 commit 9e6440e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions BoardConfigCommon.mk
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ TARGET_KERNEL_SOURCE := kernel/samsung/klte

# Audio
BOARD_HAVE_NEW_QCOM_CSDCLIENT := true
BOARD_USES_DEFAULT_BW_SR_FOR_CALLS := true
AUDIO_FEATURE_DISABLED_ANC_HEADSET := true
AUDIO_FEATURE_DISABLED_FM := true
AUDIO_FEATURE_DISABLED_MULTI_VOICE_SESSIONS := true
Expand Down

7 comments on commit 9e6440e

@deVorteX
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still doesn't seem to work for me, I have to remove the ifdef from qcom_audio-caf.

@Albinoman887
Copy link
Member

@Albinoman887 Albinoman887 commented on 9e6440e Feb 11, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deVorteX
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically working with this: http://review.cyanogenmod.org/#/c/87378/
The bug is that when you are on a call, and another call comes via call waiting, the audio for the current call cuts out completely, no tx or rx. If you toggle speaker on/off, it returns to normal. The problem is the phone switching the bit and samplerates initially, then they change again as soon as call waiting or a dial-pad tone is played. The linked patch fixes that. This commit here was intended to work with that patch, but I swear it doesn't work for me.

The only way I can get it to actually fix the issue is by removing the ifdef from that linked patch.

@deVorteX
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it possibly be dirty flashing, or not wiping system? Like is it an issue on my device, but the code is sound? I don't want to wipe everything :(, LOL

@deVorteX
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Matt, you can revert this at your convenience. It's not needed any more with a new patch that replaces the old one.

@Albinoman887
Copy link
Member

@Albinoman887 Albinoman887 commented on 9e6440e Feb 12, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deVorteX
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the new patch is already merged...http://review.cyanogenmod.org/#/c/88576/

Please sign in to comment.