-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#105 #110
Merged
Merged
Feature/#105 #110
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3772aeb
feat: 초기 로그인시 pending으로 가입
GayeongKimm 3c75dfe
fix: git error
GayeongKimm 75bfdf0
feat: 회원가입시 pending으로 회원가입 && param을 통한 유저 불러오기
GayeongKimm fd191a7
Merge branch 'master' of https://github.com/Team-B1ND/dodamdodam-serv…
GayeongKimm 83947df
chore: controller에서(id) 삭제
GayeongKimm ee82417
chore: status별로 조회할 수 있도록 메서드 추가
GayeongKimm 56497ad
chore: 사용하지 않는 Exception코드 삭제
GayeongKimm 9bc6dc5
refac: status DEACTIVATE -> DEACTIVATED로 변경 && 회원가입시 유효성 검사 if문 수정
GayeongKimm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,6 @@ | |
|
||
public enum ActiveStatus { | ||
|
||
ACTIVE, DEACTIVATE | ||
ACTIVE, DEACTIVATE, PENDING, DEACTIVATED | ||
|
||
} |
11 changes: 0 additions & 11 deletions
11
...n-rds/src/main/java/b1nd/dodam/domain/rds/member/exception/DeactivateMemberException.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
...in-rds/src/main/java/b1nd/dodam/domain/rds/member/exception/MemberNotActiveException.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package b1nd.dodam.domain.rds.member.exception; | ||
|
||
import b1nd.dodam.core.exception.CustomException; | ||
|
||
public class MemberNotActiveException extends CustomException { | ||
|
||
public MemberNotActiveException() { | ||
super(MemberExceptionCode.MEMBER_NOT_ACTIVE); | ||
} | ||
} |
12 changes: 0 additions & 12 deletions
12
...omain-rds/src/main/java/b1nd/dodam/domain/rds/member/exception/UnauthorizedException.java
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updateStatus 같이 동사를 추가해서 네이밍해주세요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 updateStatus메서드를 사용하는 기존 메서드가 있어서 임시로 네이밍을 해뒀습니다
웹에서 변경사항에 맞춰 수정하면 기존메서드를 삭제하고 메서드 명도 updateStatus로 변경할 예정입니다.