Feature/#99 #103
Merged
Feature/#99 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dongchandev
reviewed
Aug 20, 2024
| @@ -44,8 +44,10 @@ public class Member extends BaseEntity { | |||
| @NotNull | |||
| private String phone; | |||
|
|
|||
| private String parentPhone; | |||
There was a problem hiding this comment.
부모님 번호는 공통 정보가 아니라 학생의 정보이므로 굳이 member 에 추가하기 보다는 student에 추가하는게 맞는 것 같습니다
dongchandev
reviewed
Aug 20, 2024
|
|
||
| case TEACHER: | ||
| updateMemberInfo(id, req); | ||
| Teacher teacher = service.getTeacherBy(service.getMemberBy(id)); |
There was a problem hiding this comment.
공통 부분을 switch case 문에 넣을 필요가 없어 보입니다
suw0n
reviewed
Aug 20, 2024
...system-domain/dodam-domain-rds/src/main/java/b1nd/dodam/domain/rds/member/entity/Member.java
Outdated
Show resolved
Hide resolved
...ystem-domain/dodam-domain-rds/src/main/java/b1nd/dodam/domain/rds/member/entity/Teacher.java
Outdated
Show resolved
Hide resolved
...on/dodam-rest-api/src/main/java/b1nd/dodam/restapi/member/presentation/MemberController.java
Outdated
Show resolved
Hide resolved
...on/dodam-rest-api/src/main/java/b1nd/dodam/restapi/member/presentation/MemberController.java
Outdated
Show resolved
Hide resolved
suw0n
requested changes
Aug 21, 2024
...ystem-domain/dodam-domain-rds/src/main/java/b1nd/dodam/domain/rds/member/entity/Student.java
Outdated
Show resolved
Hide resolved
...system-domain/dodam-domain-rds/src/main/java/b1nd/dodam/domain/rds/member/entity/Member.java
Show resolved
Hide resolved
...on/dodam-rest-api/src/main/java/b1nd/dodam/restapi/member/presentation/MemberController.java
Show resolved
Hide resolved
suw0n
approved these changes
Aug 24, 2024
|
학생 회원가입할 때, 부모님 전화번호도 받게하는 부분이랑 관리자가 부모님 전화번호를 변경하는 부분만 남기고 머지한 후에 비밀번호 재설정 같은 부분은 다른 이슈에서 작업하는게 좋을 것 같아요. |
|
👏👏👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항 :