-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#99 #103
Feature/#99 #103
Conversation
@@ -44,8 +44,10 @@ public class Member extends BaseEntity { | |||
@NotNull | |||
private String phone; | |||
|
|||
private String parentPhone; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
부모님 번호는 공통 정보가 아니라 학생의 정보이므로 굳이 member 에 추가하기 보다는 student에 추가하는게 맞는 것 같습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NotNull 도 추가해주세요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네
|
||
case TEACHER: | ||
updateMemberInfo(id, req); | ||
Teacher teacher = service.getTeacherBy(service.getMemberBy(id)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
공통 부분을 switch case 문에 넣을 필요가 없어 보입니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네
...system-domain/dodam-domain-rds/src/main/java/b1nd/dodam/domain/rds/member/entity/Member.java
Outdated
Show resolved
Hide resolved
...ystem-domain/dodam-domain-rds/src/main/java/b1nd/dodam/domain/rds/member/entity/Teacher.java
Outdated
Show resolved
Hide resolved
...on/dodam-rest-api/src/main/java/b1nd/dodam/restapi/member/presentation/MemberController.java
Outdated
Show resolved
Hide resolved
...on/dodam-rest-api/src/main/java/b1nd/dodam/restapi/member/presentation/MemberController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전반적인 코드 스타일도 한 번 체크해주세요
...ystem-domain/dodam-domain-rds/src/main/java/b1nd/dodam/domain/rds/member/entity/Student.java
Outdated
Show resolved
Hide resolved
...system-domain/dodam-domain-rds/src/main/java/b1nd/dodam/domain/rds/member/entity/Member.java
Show resolved
Hide resolved
...on/dodam-rest-api/src/main/java/b1nd/dodam/restapi/member/presentation/MemberController.java
Show resolved
Hide resolved
학생 회원가입할 때, 부모님 전화번호도 받게하는 부분이랑 관리자가 부모님 전화번호를 변경하는 부분만 남기고 머지한 후에 비밀번호 재설정 같은 부분은 다른 이슈에서 작업하는게 좋을 것 같아요. |
👏👏👏 |
변경사항 :