Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dodam teacher module #159

Merged
merged 9 commits into from
Aug 13, 2024
Merged

Dodam teacher module #159

merged 9 commits into from
Aug 13, 2024

Conversation

8954sood
Copy link
Member

Overview (Required)

  • For CMM, I tried to work with Xcode, but the module was still not recognized with the old version, so I solved it by uploading the Kotlin version and the rest of the module version.
  • Create MultiplatformFeature, MultiplatformCompose Plugin
  • Kotlin Version Up 1.9.22 To 2.0.0

Issue

@8954sood
build: Kotlin Version Up to 2.0.0
c3c5e71 
KMM을 위해 여러방도를 찾던중 코틀린 버전을 올리니 해결되었습니다.
@8954sood
feat: Create Dodam Teacher Android/iOS File
71f3a5c
@8954sood
feat: Connect iOS Compose View
9da7879
@8954sood
style: Apply Spotless Format
bb86bed
@8954sood
build: Kotlin 2.0 Jvm Target
c0a095e 
kotlin 2.0에서 jvm target을 설정하는 방법이 바뀌어 반영하였습니다.
@8954sood
feat: Create Multiplatform Feature, Compose Plugin
31ec9c3
@8954sood 8954sood added the enhancement New feature or request label Aug 12, 2024
@8954sood 8954sood self-assigned this Aug 12, 2024
wsi1212
wsi1212 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@wsi1212 wsi1212 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dodam Teacher LGTM!! 🥰

SeokgyuYun
SeokgyuYun reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@SeokgyuYun SeokgyuYun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iosApp을 dodam-teacher-ios로 변경하고 dodam-teacher를 dodam-teacher-android로 변경하면 구분하기 좋을 것 같아요.

@8954sood
chore: Edit Dodam Teacher Bundle Id And App Name
63ac8ad
@8954sood
chore: Rename Dodam Teacher Module Name
aff19ed 
iosApp -> dodam-teacher-ios, dodam-teacher -> dodam-teacher-android
@8954sood
Copy link
Member Author

iosApp을 dodam-teacher-ios로 변경하고 dodam-teacher를 dodam-teacher-android로 변경하면 구분하기 좋을 것 같아요.

반영하였습니다.

@8954sood 8954sood merged commit 793ec8f into develop Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeokgyuYun SeokgyuYun SeokgyuYun left review comments

@wsi1212 wsi1212 wsi1212 approved these changes

Assignees

@8954sood 8954sood

Labels
enhancement New feature or request
Projects
None yet
Milestone
Dodamdodam Teacher development
Development

Successfully merging this pull request may close these issues.

Create Dodam Teacher Android/iOS Module
3 participants
@8954sood @SeokgyuYun @wsi1212