Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/KMP Network Modules #155

Merged
merged 39 commits into from
Aug 3, 2024
Merged

Conversation

8954sood
Copy link
Member

@8954sood 8954sood commented Aug 2, 2024

Overview (Required)

  • Originally, I planned to modify only the network layer in that branch, but there were too many modules that were linked, so I modified it all at once.
  • Add Logging Module(with KmLog)
  • I have switched Keystore to KMM module, but there is no keychain for iOS yet.
  • Refactor Datastore Module to KMM module
  • Refactor Common Module to KMM module
  • Create Multiplatform plugins
  • Refactor Network layer modules to KMM Module And Add Service Test Code

Issue

기존 KmLog 라이브러리의 버전 충돌로, 해당 라이브러리에서 KMM에 필요한 코드만 이식하여 모듈로 만들었습니다.
@8954sood 8954sood added enhancement New feature or request refactoring Refactor code labels Aug 2, 2024
@8954sood 8954sood self-assigned this Aug 2, 2024
@8954sood 8954sood requested a review from wnsgur1 August 2, 2024 10:26
Copy link
Member

@SeokgyuYun SeokgyuYun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@wsi1212 wsi1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 😝

@8954sood 8954sood merged commit 753cd86 into develop Aug 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create KMP Network Modules
3 participants