Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hilt dependency #153

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Conversation

8954sood
Copy link
Member

Overview (Required)

  • Remove Hilt Dependency
  • Change hiltViewModel to koinViewModel
  • Add ViewModelModule

Issue

@8954sood 8954sood added the refactoring Refactor code label Jul 21, 2024
@8954sood 8954sood self-assigned this Jul 21, 2024
Copy link
Member

@SeokgyuYun SeokgyuYun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오류 없이 모든 기능 잘 작동하나요?

@8954sood
Copy link
Member Author

오류 없이 모든 기능 잘 작동하나요?

네 매우 잘 작동합니다.

@8954sood 8954sood requested a review from SeokgyuYun July 21, 2024 11:09
loginViewModelModule,
registerViewModelModule,
settingViewModelModule,
) + mainViewModelModules,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move mainViewModelModules in list

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move mainViewModelModules in list

다음과 같이 처리한 이유는 의존성 트리때문에 그렇습니다.

  • DodamApp
    • main
      • member
      • home
      • nightstudy
      • etc..
    • login
    • register
    • etc...
      그래서, member, home, nightstudy등 모두 main에서만 접근하고 있기에 하위모듈들을 올리고자 main에서 List로 묶어 모듈을 묶었습니다. 그리고 난뒤 DodamApplication 에서 참조해서 사용하고 있습니다.

@8954sood 8954sood requested a review from wsi1212 July 23, 2024 11:30
@8954sood 8954sood merged commit cdbf830 into develop Jul 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Hilt Dependency
3 participants