Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese language support #3279

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ttimasdf
Copy link
Contributor

Building on the previous point: #3270 (comment),

I managed to get zh_Hans working in vue 2 (current branch) by symlinking vue/src/locales/zh.json to vue/src/locales/zh_Hans.json at ttimasdf@63d59cc . Although it works for me, it prevents Traditional Chinese translations in frontend from being applied.

This change is rather opinionated. since:

  1. I, as a native speaker of Simplified Chinese, can read Traditional Chinese seamlessly and I assume native zh_hant speakers may or may not be the same correspondingly.
  2. But Traditional Chinese translation also breaks at the moment 😗, (i.e. do not appear as an option in language selection list.)

So, since making simplified Chinese the default of these two languages may be a viable workaround before any backport is available, I would respect the opinions of traditional Chinese users and of maintainers.

@ttimasdf ttimasdf changed the title Feature/lang zh Chinese language support Aug 30, 2024
@ttimasdf
Copy link
Contributor Author

For anyone interested in a Chinese build, please check out the CI builds at custom branch in my fork.

需要中文的用户,可以测试一下我分支里面打包好的容器👇

docker pull ghcr.io/ttimasdf/tandoor-recipes:custom

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2024

CLA assistant check
All committers have signed the CLA.

@ttimasdf ttimasdf marked this pull request as ready for review August 30, 2024 12:39
@vabene1111
Copy link
Collaborator

thank you very much for the work you have put into this. To be honst your second commend kinda solved the issue for me because I do not plan on making any noteworthy changes to tandoor until Vue 3. This means people can safely use your fork for a few more month (hopefully, work has been a bit slow on my part) and then just switch to my branch of tandoor again as soon as the new version is out (or as soon as they want to).

Do you think this is a good solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants