-
-
Notifications
You must be signed in to change notification settings - Fork 649
Deprecated settings #3034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smilerz
wants to merge
6
commits into
TandoorRecipes:develop
Choose a base branch
from
smilerz:deprecated_settings
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Deprecated settings #3034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved deprecated setting DEFAULT_FILE_STORAGE to STORAGE['default']
looks good to me, thanks. Wil merge this but need to setup S3 test environment first (even tough I think it should be fine). |
fliiiix
reviewed
May 21, 2024
@smilerz is there a reason you closed this? I know it cannot easily be merged anymore but I left it open to use it as a checklist when updating after the V2 release? |
Just cleanup - I'll reopen it for reference. |
awesome, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved deprecated setting STATICFILES_STORAGE to STORAGE['staticfiles']
moved deprecated setting DEFAULT_FILE_STORAGE to STORAGE['default']
removed deprecated setting I10N
address deprecated .save() in Factory._after_postgeneration
change all naive datetimes to timezone aware dateimes
add ability to run tests in parrallel