Skip to content

docs(react-mutations): replace accidentally-deleted content in mutations.md #9254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

christina-de-martinez
Copy link
Contributor

I was reading about mutations and was surprised when the guide ended mid-sentence. It looks like part of the content was deleted during a fairly large, maybe partially automated commit: afc6302#diff-45f03e5c0424761a02a9cd83196c99693f26087f2e9b5d265c0eea53fa3bcaad

This PR assumes that you want this part of the guide put back. Feel free to close this if that's not the case :)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 6, 2025
@christina-de-martinez christina-de-martinez changed the title docs: Replace accidentally-deleted content in mutations.md docs(react-mutations): replace accidentally-deleted content in mutations.md Jun 6, 2025
@TkDodo
Copy link
Collaborator

TkDodo commented Jun 6, 2025

this is the same PR as:

but I’m not getting any response there.

My feedback is that you please have to make sure that the links work. The accidental removal happened when we changed how all the links are built due to changes in TanStack Start. So if we just restore what we had before, the links are probably not working.

I’ll merge this regardless but I’d appreciate if you could file another PR that fixes the links on this page.

@TkDodo TkDodo merged commit eae7bde into TanStack:main Jun 6, 2025
1 check passed
@christina-de-martinez
Copy link
Contributor Author

Right, sorry, here's a follow-up PR that should fix those: #9260 @TkDodo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants