Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Support to make neovim numhl of sign fade. #39

Open
kevinhwang91 opened this issue Jan 31, 2020 · 2 comments
Open

[Feature request] Support to make neovim numhl of sign fade. #39

kevinhwang91 opened this issue Jan 31, 2020 · 2 comments

Comments

@kevinhwang91
Copy link

I saw some code in signs.py about linehl were commented.

      # linehl adds high performance hit -- maybe add toggle for this
      # if 'linehl' in item:
        # linehl_id = vim.eval('hlID("'+item['linehl']+'")')
        # if linehl_id:
          # ids.append(linehl_id)
        # definition += ' linehl=vimade_' + linehl_id

and numhl of sign works after I added below code.

      if 'numhl' in item:
        numhl_id = vim.eval('hlID("'+item['numhl']+'")')
        if numhl_id:
          ids.append(numhl_id)
        definition += ' numhl=vimade_' + numhl_id

But it must make sure that the option checkinterval of vimade greater than the option updatetime of neovim, otherwise, vim-gitgutter enabled g:gitgutter_highlight_linenrs = 1 may works unexpected.

I don't know why, please support this feature with bug-free code.

@TaDaa
Copy link
Owner

TaDaa commented Jan 31, 2020

Will get the issue you are talking about resolved, its been there in the back of my mind but I keep putting it off.

+1 for supporting numhl. I want to say linehl should be supportable at this point on neovim as well given all the highlighting performance improvements it currently has over vim -- will look into re-enabling it.

TaDaa added a commit that referenced this issue Feb 3, 2020
…d vim. Fixed sign prioritization when multiple signs share the same priority or should be ranked higher. Reduced sign ipc
@TaDaa
Copy link
Owner

TaDaa commented Feb 3, 2020

linehl and numhl should now be supported with some perf improvements and logic for sign prioritization.

Currently considering options to catch signs that might be triggered off of updatetime -- likely will update vimade to consult both signsretentionperiod and updatetime, which should handle most plugins without specific configurations. Should have an update on this one in a day or 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants