-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vimade doesn't seem to be doing anything in terminal mode #1
Comments
Terminal is still a wip, currently it only supports the xterm 256 palette, but I can take a look as soon as I get some free time to see about adding gnome + tilda. Which colorscheme are you using? |
I'm experiencing the same on Alacritty and Tmux. I'm using quantum |
Second that. tmux + alacritty + base16 color schemes (both bash and vim). |
I use a solarized palette in urxvt. |
It seems to work on Alacritty if you set termguicolors, but if possible, it would be nice to have it function without termguicolors being set. |
i'm on a slightly customised lucius colorscheme. didn't realize it would matter. |
pushed a fix where the normalid couldn't be resolved in some terminals, see if this resolves the issues for you guys |
Working for me in gnome-terminal. The first time I exited there was an error printed on the terminal from vimade, some python problem, but trying to replicate it, I can't get it to come back again. I'll keep an eye out. Works in tmux too! |
Happened again but I can't reproduce it faithfully at all:
shows up on exit. Probably 1 in 15 exits will have this shown. |
always a complaint on line 18? Also you on vim or neovim? I do see some similar errors floating around on neovim, issues with python threading or something -- but I'll have to get neovim setup later on my VM to debug |
no difference in my case, unfortunately :( |
@TaDaa yes, line 18, and I'm on neovim. |
@Ch00k sorry about that -- its taking me some time to setup alacritty (only have it working on mac atm) -- which OS are you using alacritty on? -- Also what is your output for "echo &t_Co" and "echo g:vimade"? |
@TaDaa I use macOS 10.13.6. I just tried to run vim inside and outside of tmux, and both the echo's produce the same result:
|
Running 10.14.1, works in alacritty + tmux 2.8 for me (unless I set termguicolors, that seems to break syntax highlighting in general). Does your :messages contain errors? Is syntax highlighting normally? Does vimade work in Alacritty by itself, if not does it work in the default terminal? |
You may see some change now! For terminal there was a possibility that ctermfg/ctermbg does not get set (when it uses the terminal defaults). There isn't a 100% way of getting the terminal settings (and tmux n, but Vimade should at least try now and default to 0/248 if it can't. I think for best results on Alacritty, vimade needs a colorscheme that specifies Normal or vimade needs to be configured using g:vimade.basebg and g:vimade.basefg. I could not find a way to make Alacritty print out the colors like other xterm terminals could (so if any of you know how, let me know -- I may ask on their github later if not) |
Spoke too soon, almost there |
I can confirm the plugin works for native OSX (10.13.6) terminal app (xterm-256color). |
The latest code works for me in tmux with vim base16 colorscheme. Although vim startup is pretty slow now, and
I have no custom vimade variables defined in my vimrc. |
Same Issue here |
Slowness should be fixed now guys and messages should be gone -- the terminal support should overall be a better experience I am hoping... Here is what is supported: Neovim is not supported for autodetection of background/foreground yet. Instead vimade will default the fades based on white/black or vice versa depending on whether &background is light or dark...I am working on supporting autodetection on neovim and have a partially working hack but it requires hijacking the UI tty (since neovim is actually not the tty). I am a bit hesitant to put the hack in because its a bit fragile, but it might lead me to a better solution soon. |
Couple of Alacritty users here, so I opened an issue on Alacritty git regarding the ANSI codes not working, maybe they have an alternative |
NVIM v0.4.0-762-g9420a2127 (AppImage), gnome-terminal After having installed vimade with Vim-Plug: |
Neovim v0.4.3 and Nord theme, using iTerm2 v3.3.9. I'm a front-end dev so entirely possible I'm doing something stupid but very little seems to change between panes. Attaching a grab whereby the top pane is active — notice that only some characters get dimmed/re-colored and line-numbers are unaffected. This is using this config for vimmade:
|
May need a minimal vimrc/init.vim and I'll try to reproduce the issue. Also are you using tmux and is nvim using termguicolors or is it in 256 color mode? |
@TaDaa Hi! no tmux, my init.vim is here - that was saved up just before adding vimade as per earlier comment. Here is the bit in the init.vim regarding colours:
|
Thanks @benfrain Few questions:
|
=> xterm-256color
=> 0 BTW - I have noticed that if I open a split with Is that because the |
That is right, The partial highlighting is still strange to me, I have not been able to reproduce the issue, but we are also seeing different results in 256color mode (my background shows as black and not the nord theme). It is possible that in 256color the approximation for the fade somehow calculated too close to the Normal ctermfg, which would result in the same color text. Might be worth trying to adjust the fadelevel to 0.3 or 0.2 and see if the text changes color at all. I will say termguicolors produces much better results if its an option for you. |
Great plugin! I've installed using native vim rtp loading and it seems to be working fine in GUI, but it isn't doing anything in terminal mode. How can i efficiently debug this issue? I'm using Tango palette in gnome-terminal and tilda, inside and outside of tmux, and 256 color support is working just fine, even true color in the apps that support it.
The text was updated successfully, but these errors were encountered: