Convert cypher expression to lynxExpression of match #371
+34
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LianxinGao
changed the title
| )(implicit plannerContext: LogicalPlannerContext | ||
| ): LogicalNode = { | ||
| //run match | ||
|
|
Contributor
There was a problem hiding this comment.
Remove empty newline
Comment on lines
+68
to
+73
| val newLeftNodePattern = | ||
| ConvertPatternExpressionToLynxExpression.convertNodePattern(leftNode) | ||
| val newRelationshipPattern = | ||
| ConvertPatternExpressionToLynxExpression.convertRelationshipPattern(relationship) | ||
| val newRightNodePattern = | ||
| ConvertPatternExpressionToLynxExpression.convertNodePattern(rightNode) |
Contributor
There was a problem hiding this comment.
No need to assign vals here. Should be able to do this in-place in line 75
LianxinGao
changed the title
LianxinGao
changed the title
zyang-tudb
approved these changes
Oct 25, 2022
| element match { | ||
| //match (m:label1) | ||
| case np: NodePattern => | ||
| LogicalPatternMatch(np, Seq.empty) |
| relationship: RelationshipPattern, | ||
| rightNode: NodePattern | ||
| ) => | ||
| val mp = matchPattern(leftChain) |
Contributor
There was a problem hiding this comment.
mp->leftRelationshipChain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
as title
Why are the changes needed?
First step of DeCypher
Does this PR introduce any user-facing change?
No
How was this patch tested?
Not yet