Hook: Added hook "TTT2PlayDeathScream" for deathscreams #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woohoo, awesome to see this making it in!
|
|
(any feedback appreciated) |
Histalek
reviewed
Oct 20, 2024
Changed isSilent to be a extra param in the hook itself. It will only be used by the GM hook if no other hook returns something.
|
Latest commit changed to how isSilent should be handled instead, as per suggestion. |
TimGoll
reviewed
Oct 24, 2024
TimGoll
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hook allows to change the sound of the deathscream or cancel it outright.
Maybe I'm mistaken but I thought the table approach would be the most appropriate one here. Please correct me if not.
Changelog will follow when this is done.