Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addonchecker: Added diagnostics and GMOD version check #1665

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

NickCloudAT
Copy link
Contributor

This adds a bit more information to the end of the addonchecker for diagnostic purpose.
It also contains a Garry's Mod Version check for the minimum required version which TTT2 can run on.

Print will look like this:

Compatible Version:

image

Not compatible:

image

I sadly don't know which version of GMOD is the current exact minimum on which TTT2 will still run on.

This is a draft, all input welcome :)

(Changelog etc. will follow if accepted and done)

@TimGoll
Copy link
Member

TimGoll commented Oct 13, 2024

I can't tell you the exact minimum. But it should be the February 2024 update. The one wher net.ReadPlayer was added

https://wiki.facepunch.com/gmod/net.ReadPlayer

There is a version linked there. Maybe it helps?

@NickCloudAT
Copy link
Contributor Author

I can't tell you the exact minimum. But it should be the February 2024 update. The one wher net.ReadPlayer was added

https://wiki.facepunch.com/gmod/net.ReadPlayer

There is a version linked there. Maybe it helps?

Ah, yeah that helps. That would be version string "20231006" which I could set of course.

@TimGoll
Copy link
Member

TimGoll commented Oct 13, 2024

I can't tell you the exact minimum. But it should be the February 2024 update. The one wher net.ReadPlayer was added
https://wiki.facepunch.com/gmod/net.ReadPlayer
There is a version linked there. Maybe it helps?

Ah, yeah that helps. That would be version string "20231006" which I could set of course.

Hm. That update was released in the beginning of 2024 though. So the year seems wrong? Maybe it was only the dev branch of that year?

@NickCloudAT
Copy link
Contributor Author

I can't tell you the exact minimum. But it should be the February 2024 update. The one wher net.ReadPlayer was added
https://wiki.facepunch.com/gmod/net.ReadPlayer
There is a version linked there. Maybe it helps?

Ah, yeah that helps. That would be version string "20231006" which I could set of course.

Hm. That update was released in the beginning of 2024 though. So the year seems wrong? Maybe it was only the dev branch of that year?

Yeah I just noticed.. I would guess it's the date of first implementation, not public release :/
I mean, theoretically we could just set the current GMOD version as the "baseline".. All servers should be up-to-date anyway.

@NickCloudAT NickCloudAT marked this pull request as ready for review October 14, 2024 16:27
@NickCloudAT
Copy link
Contributor Author

I guess ready for review.

Copy link
Member

@Histalek Histalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find and cool addition!

It's a pity that we can't get the branch the server is using, but oh well

gamemodes/terrortown/gamemode/server/sv_addonchecker.lua Outdated Show resolved Hide resolved
@Histalek Histalek enabled auto-merge (squash) October 14, 2024 17:41
@Histalek Histalek merged commit 35d18a4 into TTT-2:master Oct 14, 2024
4 checks passed
@NickCloudAT NickCloudAT deleted the version_check branch October 15, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants