Fix weapon pickup through walls #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed bug that allows weapons to be picked up through walls. When trace starts solid (for example large weapon spawned too close to wall) then tr.Fraction can return 1.0 through solid walls.
Fix weapon pickup through walls
|
What a nice catch, wow! This was probably mostly an error when auto pickup is enabled, am I right? Could you please add yourself to the changelog? |
added myself to changelog
TimGoll
approved these changes
Oct 8, 2024
|
Yep! Absolutely no issue without auto pickup since you cant select the weapons through walls, unfortunately people were raiding my traitor room on my current mapping project with auto pickup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check for trace start solid to prevent teleporting weapon through walls.
Edgecases can occur where weapons can be picked up through walls (even thick 16 unit walls didn't prevent this). This is because the trace can start solid (most likely if the weapon is too large for the space its resting, in my case a relatively small func_detail shelf) and then the tr.Fraction will return 1.0 through a solid wall, causing weapons the be teleported and picked up.