Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language: Add Korean translation. #1659

Merged
merged 10 commits into from
Oct 24, 2024
Merged

Language: Add Korean translation. #1659

merged 10 commits into from
Oct 24, 2024

Conversation

kojap
Copy link
Contributor

@kojap kojap commented Oct 2, 2024

It's not complete translation, but it's translated enough to play.

I made it for users who play TTT2 in Korea.

Copy link
Member

@TimGoll TimGoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either remove or comment out all lines that are still in english. TTT2 automatically uses english as a fallback if a line is not defined. If you do it your way, the it is hard for future contributors the see which lines are missing

@TimGoll TimGoll added this to the v0.14.1b milestone Oct 2, 2024
@TimGoll TimGoll added the type/enhancement Enhancement or simple change to existing functionality label Oct 2, 2024
Commented out untranslated sentences.
lua/terrortown/lang/ko.lua Outdated Show resolved Hide resolved
@TimGoll
Copy link
Member

TimGoll commented Oct 2, 2024

Also, no comment blocks, only single line comments. But you can also just delete everything that is not a Korean translation line. Our language tool will fix the file then

kojap and others added 2 commits October 3, 2024 01:56
Everything that is not a Korean translation line is Deleted
@TimGoll
Copy link
Member

TimGoll commented Oct 3, 2024

I ran the language parser and you have a few issues to resolve:

[ERROR] in ko.lua: 1 missing param(s) in traslation string with the following identifier: tip23
[ERROR] - reference:   Press {helpkey} to view a short tutorial or modify some TTT-specific settings.
[ERROR] - translation: 무기와 다르게, C4와 라디오는 설치자의 DNA를 남기지 않습니다. 탐정이 이를 발견하는것을 겁내지 마세요, 들키지 않을 겁니다.
[ERROR] - missing:     ['helpkey']

[ERROR] in ko.lua: 1 unused param(s) in traslation string with the following identifier: tip24
[ERROR] - reference:   When a Detective searches a body, the result is available to all players via the scoreboard by clicking on the name of the dead person.
[ERROR] - translation: {helpkey} 키를 눌러 짧은 튜토리얼과 TTT 옵션을 설정 할 수 있습니다. 예를들어, 팁을 영원히 꺼버릴 수 있습니다.
[ERROR] - unused:      ['helpkey']

[ERROR] in ko.lua: 1 missing param(s) in traslation string with the following identifier: tip27
[ERROR] - reference:   Spectators can press {mutekey} to cycle through muting other spectators or living players.
[ERROR] - translation: 탐정으로 플레이 할 때, 닉네임 옆에 있는 돋보기 아이콘은 탐정이 이미 이 시체를 조사했다는 소리이며, 결과는 모든 사람들에게 전해집니다.
[ERROR] - missing:     ['mutekey']

[ERROR] in ko.lua: 1 missing param(s) in traslation string with the following identifier: tip28
[ERROR] - reference:   You can switch to a different language at any time in the Settings menu by pressing {helpkey}.
[ERROR] - translation: 관전자들은 {mutekey} 키로 다른 관전자나 살아있는 사람을 뮤트 할 수 있습니다.
[ERROR] - missing:     ['helpkey']

[ERROR] in ko.lua: 1 unused param(s) in traslation string with the following identifier: tip28
[ERROR] - reference:   You can switch to a different language at any time in the Settings menu by pressing {helpkey}.
[ERROR] - translation: 관전자들은 {mutekey} 키로 다른 관전자나 살아있는 사람을 뮤트 할 수 있습니다.
[ERROR] - unused:      ['mutekey']

[ERROR] in ko.lua: 1 missing param(s) in traslation string with the following identifier: tip29
[ERROR] - reference:   Quickchat or 'radio' commands can be used by pressing {zoomkey}.
[ERROR] - translation: 이 서버에 추가적인 언어가 설치되어 있다면, 세팅 메뉴에서 언제든지 언어를 바꿀 수 있습니다.
[ERROR] - missing:     ['zoomkey']

[ERROR] in ko.lua: 1 unused param(s) in traslation string with the following identifier: tip30
[ERROR] - reference:   The Crowbar's secondary fire will push other players.
[ERROR] - translation: 퀵쳇이나 라디오 커맨드는 {zoomkey}를 눌러 사용할 수 있습니다.
[ERROR] - unused:      ['zoomkey']

[ERROR] in ko.lua: 2 unused param(s) in traslation string with the following identifier: tip31
[ERROR] - reference:   Firing through the ironsights of a weapon will slightly increase your accuracy and decrease recoil. Crouching does not.
[ERROR] - translation: 관전자 시점에서, {duckkey} 키를 누르면 마우스 커서가 보여지고, 팁 패널을 누를 수 있게 됩니다. 다시 {duckkey}를 눌러 관전모드로 전환 가능합니다.
[ERROR] - unused:      ['duckkey', 'duckkey']

[ERROR] in ko.lua: 1 unused param(s) in traslation string with the following identifier: tip36
[ERROR] - reference:   C4 that explodes due to a mistake in disarming it has a smaller explosion than C4 that reaches zero on its timer.
[ERROR] - translation: 튜토리얼은 {helpkey}키를 눌러 활성화 가능합니다. 게임을 플레이 하는데 중요한 키 배치를 볼 수 있습니다.
[ERROR] - unused:      ['helpkey']

[ERROR] in ko.lua: 1 missing param(s) in traslation string with the following identifier: tip38
[ERROR] - reference:   You can pick up focused weapons by pressing {usekey}. It will automatically drop you blocking weapon.
[ERROR] - translation: 설치형 장비들(라디오나 C4계열)은 우클릭으로 벽에 붙일 수 있습니다.
[ERROR] - missing:     ['usekey']

[ERROR] in ko.lua: 1 missing param(s) in traslation string with the following identifier: tip39
[ERROR] - reference:   You can change your key bindings in the bindings menu, located in the Settings menu opened with {helpkey}.
[ERROR] - translation: C4를 해체하다가 실패하여 발생하는 폭발은 C4가 시간이 되어 폭발하는 것 보다 더 적은 범위를 가집니다.
[ERROR] - missing:     ['helpkey']

@TimGoll
Copy link
Member

TimGoll commented Oct 3, 2024

I also noticed that your tips are from the original TTT language file. We removed some tips, because they are no longer relevant to TTT2. Therefore the tip IDs were changed. Make sure your translation match the original english ones. These ID misalignments are probably also the reason for the errors I just posted

@TimGoll
Copy link
Member

TimGoll commented Oct 24, 2024

Since you didn't do anything, I will remove the tip translations so we can merge that. If you want to re-add them at some point, feel free to open another PR. Thank you!

@TimGoll TimGoll merged commit ed758fa into TTT-2:master Oct 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement or simple change to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants