Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pre-commit): add config #2339

Merged
merged 2 commits into from
Mar 25, 2025
Merged

ci(pre-commit): add config #2339

merged 2 commits into from
Mar 25, 2025

Conversation

nuxencs
Copy link
Contributor

@nuxencs nuxencs commented Mar 22, 2025

Pull Request

Purpose

Add a pre-commit config to rule out any errors in the most commonly edited files before even committing to the repo.

Approach

Add .pre-commit-config.yaml to the root of the repo and add json schema validation and yaml, markdown and editorconfig linting.

Requirements

@nuxencs nuxencs requested a review from a team March 22, 2025 11:53
@github-actions github-actions bot added the Area: Backend Backend Changes, not related to a specific section label Mar 22, 2025
Copy link
Contributor

@nuxencs your pull request title "feat(pre-commit): add config" does not conform to our naming conventions.

Please update the title to match the pattern: "feat|build|chore|style|fix|update|ci(<area>): <description>

You can check your title at this regex101 link."

Copy link
Contributor

Deploying with ⚡ Cloudflare Pages

Latest commit:95a0f8471e970f3f221fa7cb88269b1a2fa85984
Status: ✅  Deploy successful!
Preview URL:https://e5074fdd.trash-guides-6xu.pages.dev
Branch Preview URL:https://pr-2339.trash-guides-6xu.pages.dev

@nuxencs nuxencs changed the title feat(pre-commit): add config ci(pre-commit): add config Mar 22, 2025
Copy link
Contributor

@FonduemangVI FonduemangVI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@FonduemangVI FonduemangVI merged commit 5af261e into master Mar 25, 2025
9 of 10 checks passed
@FonduemangVI FonduemangVI deleted the feat/pre-commit-hooks branch March 25, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Backend Backend Changes, not related to a specific section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants