-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New automation component User Interface design. #13
base: master
Are you sure you want to change the base?
Conversation
"Create new device": Errorhandling incorrect ---Issue resolved
A basic User Interface for creating new automation component
Unfortunatly, these changes break the functionality of the createDevice GUI. |
…trical Interface"
Hey @Rajkumarpulaparthi! I found a few things you should change:
That's all my feedback for now. |
Hi stefan,
Sorry for the late reply.
I'm shifting from stuttgart to back to my university. Unfortunately, I
couldn't got chance to reply.
I will consider these changes and let you know, as soon as possible.
Thank you for being active and checking. I will make changes to the plugin
once I'm done with my thesis work.
Best regards
Raj kumar
<[email protected]> wrote:
… Hey @Rajkumarpulaparthi <https://github.com/Rajkumarpulaparthi>!
I just found some time to look into some of the changes you made.
First of: I like the changes you made. Even though I'm not able to fully
understand how it should work, because I don't know what it's supposed to
do. But thats fine ;)
I found a few things you should change:
1. Clicking on 'Help -> Manual' opens a link to your company's
sharepoint. Since this is internal only, I don't think it should be in this
open source project. It would be great if you could publish this manual so
other people can use it as well. If you can't publish the manual, you
should remove the link in the plugin.
2. Clicking on the red cross (see screenshot) results in a
ArgumentOutOfRangeException. This occurs in the Generic Data Tab
(DeviceDescription.cs:line 2293) and the Interfaces tab
(DeviceDescription.cs:line 1989).
[image: Screenshot_error_ArgumentOutOfRangeException]
<https://user-images.githubusercontent.com/31218621/73368230-e876d280-42b0-11ea-8265-65df9e78c3e9.png>
3. When opening the plugin, the sidebar with the class libraries is
extremly small. I don't know, if this is intended. I feel, that this
sidebar could be a bit bigger at the start.
That's all my feedback for now.
Have a good day!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13?email_source=notifications&email_token=AMB5N7AS5LRZALABXXIPTFDRAGL5ZA5CNFSM4H63O2WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKHQTUY#issuecomment-579799507>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMB5N7DKFNRHUYCDQ2BZBVLRAGL5ZANCNFSM4H63O2WA>
.
|
Lick on Create new device button on the start GUI, A basic user Interface for with options are designed.