Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New automation component User Interface design. #13

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

Rajkumarpulaparthi
Copy link

Lick on Create new device button on the start GUI, A basic user Interface for with options are designed.

"Create new device": Errorhandling incorrect ---Issue resolved
A basic User Interface for creating new automation component
@DorianSnowball
Copy link
Member

Unfortunatly, these changes break the functionality of the createDevice GUI.
You should restore the OnClick Events and add an disclaimer to the other elements, that these are work in progress.

@DorianSnowball
Copy link
Member

Hey @Rajkumarpulaparthi!
I just found some time to look into some of the changes you made.
First of: I like the changes you made. Even though I'm not able to fully understand how it should work, because I don't know what it's supposed to do. But thats fine ;)

I found a few things you should change:

  1. Clicking on 'Help -> Manual' opens a link to your company's sharepoint. Since this is internal only, I don't think it should be in this open source project. It would be great if you could publish this manual so other people can use it as well. If you can't publish the manual, you should remove the link in the plugin.
  2. Clicking on the red cross (see screenshot) results in a ArgumentOutOfRangeException. This occurs in the Generic Data Tab (DeviceDescription.cs:line 2293) and the Interfaces tab (DeviceDescription.cs:line 1989).
    Screenshot_error_ArgumentOutOfRangeException
  3. When opening the plugin, the sidebar with the class libraries is extremly small. I don't know, if this is intended. I feel, that this sidebar could be a bit bigger at the start.

That's all my feedback for now.
Have a good day!

@Rajkumarpulaparthi
Copy link
Author

Rajkumarpulaparthi commented Jan 30, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants