-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a meson.build file, tests and update the README.MD #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very experienced with github actions or with meson, so I defer to @ocefpaf for any detailed checking. It all looks reasonable, and the tests pass (a lot of tests!).
In addition to the changes you made to README, the meson additions should be added to the file list in README-developer.
LGTM. Indeed the test matrix got quite big. I wonder if we could do both shared and static in one go... But then it would be hard to find things in the logs, so probably not worth it. (And this runs quite fast, probably fine as-is.) |
remove "appears to be"
dd85726
to
be748dd
Compare
I added meson.build and meson.options to the README and README-developer file manifest. |
This adds a meson.build file (see issue #72)
I also added a related test matrix updated the README.MD to report how to build the project using meson.
The build file allows installing and testing the project using different configurations.
When installing, it also installs a package config file which should ease integrating with e.g. CMAKE
However I didn't actually test the package config file (Happy to support you if you run into problems though)
The build file also allows for directly integrating the project as subproject into existing meson
projects (this is what I use it for at the moment)
Happy to receive feedback on this PR, I'd also be happy to support maintaining this file.
Cheers