Removed enumerated values in the attribute descriptions #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trishaoconnor
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
The changes look good to me. All checks have passed and there are no issue with the tests. I've no comments/recommendations to add. It's good to merge to dev @sydb, if you also approve. Sincere thanks to you and your colleague for kindly updating the Chinese translation. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #2663 I removed the repetative enumerations in the English and French
<desc>ofatt.citing/@unitand (with help from my Chinese colleague Jiaqi) the Chinese<desc>togap/@reason.