[#12048] Migrate tests for GetHasResponsesActionTest #13289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit current changes before refactoring GetHasResponsesAction
Fix the path for execute method for migrated courses
Test execute method with some positive and negative test cases Test checkSpecificAccessControl method with some positive and negative test cases
jasonqiu212
approved these changes
Mar 30, 2025
src/test/java/teammates/sqlui/webapi/GetHasResponsesActionTest.java
Outdated
Show resolved
Hide resolved
mingyang143
added
s.ToReview
domoberzin
added
s.ToMerge
mingyang143
requested changes
Mar 30, 2025
| } | ||
|
|
||
| @Test | ||
| void testAccessControl_nonInstructor_cannotAccessResponses() { |
There was a problem hiding this comment.
I think this test can be renamed to testAccessControl_nonInstructorWithInstructorEntityParams_cannotAccessResponses for more clarity. We can also add another similar test for students with the name testAccessControl_nonStudentWithStudentEntityParams_cannotAccessResponses.
|
|
||
| verifyCannotAccess(params); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we can add a test method with the name testAccessControl_invalidParams_throwsInvalidHttpParameterException, with the following tests:
void testAccessControl_invalidParams_throwsInvalidHttpParameterException() {
loginAsStudent(typicalStudent.getGoogleId());
// Missing Entity Type in params
String[] params = new String[] {
Const.ParamsNames.COURSE_ID, typicalCourse.getId(),
};
verifyHttpParameterFailureAcl(params);
// Missing Course ID in params
String[] params1 = new String[] {
Const.ParamsNames.ENTITY_TYPE, Const.EntityType.STUDENT,
Const.ParamsNames.FEEDBACK_SESSION_NAME, typicalFeedbackSession.getName(),
};
verifyHttpParameterFailureAcl(params1);
logoutUser();
loginAsInstructor(typicalInstructor.getGoogleId());
// Missing course ID and feedback session id in params but with feedback session name in params
String[] params2 = new String[] {
Const.ParamsNames.FEEDBACK_SESSION_NAME, typicalFeedbackSession.getName(),
Const.ParamsNames.ENTITY_TYPE, Const.EntityType.INSTRUCTOR,
};
verifyHttpParameterFailureAcl(params2);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
Change GetHasResponsesActionTest.java to ensure compatibility with the PostgreSQL database following the database migration.