Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13287] Fix GetHasResponsesAction #13288

Merged
merged 2 commits into from
Mar 30, 2025
Merged

[#13287] Fix GetHasResponsesAction #13288

merged 2 commits into from
Mar 30, 2025

Conversation

BunnyHoppp
Copy link
Contributor

Fixes #13287

Outline of Solution

Modified the code that uses logic instead of sqlLogic, when it is supposed to use sqlLogic, along the path where the Course is migrated.

@BunnyHoppp
Fix path for execute()
8f31e0d 
When FeedbackSession is provided, modified student's
path to follow Sql logic, instead of Datastore logic.
@BunnyHoppp
Copy link
Contributor Author

Should there be a return after line 94, since they checked if that FeedbackSession is accessible, then we do not need to check the rest of the feedback sessions?

@jasonqiu212
Copy link
Contributor

I think we can keep the original logic!

jasonqiu212
jasonqiu212 approved these changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! good spot

@jasonqiu212 jasonqiu212 added the s.FinalReview The PR is ready for final review label Mar 29, 2025
domoberzin
domoberzin approved these changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonqiu212 jasonqiu212 merged commit b8bfb60 into TEAMMATES:master Mar 30, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@domoberzin domoberzin domoberzin approved these changes

@DhiraPT DhiraPT Awaiting requested review from DhiraPT

Assignees
No one assigned
Labels
s.FinalReview The PR is ready for final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect path for migrated courses in GetHasResponsesAction
3 participants
@BunnyHoppp @jasonqiu212 @domoberzin