Skip to content

[#12048] Migrate tests for GetFeedbackResponsesActionTest #13268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 1, 2025
Merged

[#12048] Migrate tests for GetFeedbackResponsesActionTest #13268

merged 10 commits into from
Apr 1, 2025

Conversation

mingyang143
Copy link
Contributor

Part of #12048

Outline of Solution
Change GetFeedbackResponsesActionTest to ensure compatibility with the PostgreSQL database following the database migration.

@mingyang143 mingyang143 self-assigned this Mar 15, 2025
@mingyang143 mingyang143 marked this pull request as ready for review March 17, 2025 14:10
@domoberzin domoberzin added the s.ToReview The PR is waiting for review(s) label Mar 22, 2025
jasonqiu212
jasonqiu212 approved these changes Mar 30, 2025
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! quite a long test, so not sure if i missed anything..

@jasonqiu212 jasonqiu212 added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Mar 30, 2025
dishenggg
dishenggg requested changes Mar 30, 2025
View reviewed changes
Copy link
Contributor

@dishenggg dishenggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this monster PR🫡

@dishenggg dishenggg added s.Ongoing The PR is being worked on by the author(s) and removed s.FinalReview The PR is ready for final review labels Mar 30, 2025
@mingyang143 mingyang143 requested a review from dishenggg March 30, 2025 15:44
@mingyang143
Copy link
Contributor Author

@dishenggg Thanks for your review. I just updated the PR.

@jasonqiu212 jasonqiu212 added s.FinalReview The PR is ready for final review and removed s.Ongoing The PR is being worked on by the author(s) labels Apr 1, 2025
dishenggg
dishenggg approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@dishenggg dishenggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small nits to clean up the test abit other than that LGTM!

@mingyang143 mingyang143 merged commit 110025c into TEAMMATES:master Apr 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dishenggg dishenggg dishenggg approved these changes

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

Assignees

@mingyang143 mingyang143

Labels
s.FinalReview The PR is ready for final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mingyang143 @dishenggg @jasonqiu212 @domoberzin