Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Core-CMS#v4.24 & Core-Style#v2.39 #499

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Feb 20, 2025

Overview

Update TACC/Core-CMS to test:

Important

After deploy, update snippet #141.

Related

Changes

  • updates Core CMS image

Testing

  1. Does [TUP] Update djangocms-forms dependency Core-CMS#911 achieve its goal on TUP?
  2. Do new prior Core-CMS and Core-Styles releases break anything?

UI

✅ CMS v4.20 & Core-Styles v2.37

✅ CMS v4.24 & Core-Styles v2.39

v4.20.2

Container has many options. Empty option works.
  1. Create a "Container".
  2. All options should be available.
  3. The "No container, no section" must not fail when saved.
container empty
container.empty.mov

v4.21.0

External links are forced to open in new tab.
  1. Find/Create link to external domain.
  2. Verify target="_blank" is not set manually.
  3. Save link.
  4. Reload page or "View Published".
  5. Verify target="_blank" is set automatically.
external.link.open.new.window.mov

⁉️ v4.22.0

⁉️ Bootstrap & jQuery are updated.
  1. ✅ Bootstrap is v4.6.
  2. ✅ jQuery is v3.5.
  3. ⁉️ Ajax forms still work.

Caution

Form ajax might fail. See TACC/Core-CMS#912.

Tip

Ajax failure might be fixed by 3a614e4.

bootstrap jquery
bootstrap jquery
Alignment of logo and nav link good or better.

Snippet tweak required.

  1. Nav links in header should be aligned as well as in production or better.
  2. Logo in header should be aligned as well as in production or better.
header item alignment

v4.23.0

New Automatic User Groups
  1. Open Groups.
  2. See old manual group(s) exist e.g. "Bootstrap Grid Editor".
  3. See new automatic groups exist e.g. "Grid Editor (Advanced)".
v4 23 0

v4.24.0

Header resize and hide/show has no bugs.
  1. View site on wide enough window that menu bar is visible.
  2. Resize window wider and smaller.
  3. Verify no bugs in header UI.
  4. View site on narrow enough window that menu bar is not visible.
  5. Both show and hide and show menu.
  6. Roll over nav links when menu is shown.
  7. Verify no bugs in header UI.
header.open.close.mov

@wesleyboar wesleyboar changed the title feat: TACC/Core-CMS#v4.24.0 & Core-CMS#911 feat: Core-CMS#v4.24.0 & Core-CMS#911 Feb 20, 2025
@wesleyboar wesleyboar changed the title feat: Core-CMS#v4.24.0 & Core-CMS#911 feat: Core-CMS#v4.24.1 Feb 20, 2025
@wesleyboar wesleyboar changed the title feat: Core-CMS#v4.24.1 feat: Core-CMS#v4.24 & Core-Style#v2.39 Feb 20, 2025
Copy link
Member Author

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Might cause form ajax to fail. See TACC/Core-CMS#912.

Tip

Ajax failure may be resolved by 3a614e4.

@wesleyboar wesleyboar marked this pull request as draft February 24, 2025 23:40
@wesleyboar wesleyboar changed the title feat: Core-CMS#v4.24 & Core-Style#v2.39 ⚠️ feat: Core-CMS#v4.24 & Core-Style#v2.39 Feb 24, 2025
@wesleyboar wesleyboar changed the title ⚠️ feat: Core-CMS#v4.24 & Core-Style#v2.39 feat: Core-CMS#v4.24 & Core-Style#v2.39 Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants