-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Core-CMS#v4.24 & Core-Style#v2.39 #499
Draft
wesleyboar
wants to merge
8
commits into
main
Choose a base branch
from
feat/core-cms-v4.24.0-and-core-cms-pr-911
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 20, 2025
Header CSS changed, so this snippet must change.
Previous image was for PR/brnach that has been merged and released.
wesleyboar
commented
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Might cause form ajax to fail. See TACC/Core-CMS#912.
Tip
Ajax failure may be resolved by 3a614e4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update TACC/Core-CMS to test:
Important
After deploy, update snippet #141.
Related
Changes
Testing
UI
✅ CMS v4.20 & Core-Styles v2.37
✅ CMS v4.24 & Core-Styles v2.39
v4.20.2
Container has many options. Empty option works.
container.empty.mov
✅ v4.21.0
External links are forced to open in new tab.
target="_blank"
is not set manually.target="_blank"
is set automatically.external.link.open.new.window.mov
Caution
Form ajax might fail. See TACC/Core-CMS#912.
Tip
Ajax failure might be fixed by 3a614e4.
Alignment of logo and nav link good or better.
Snippet tweak required.
✅ v4.23.0
New Automatic User Groups
✅ v4.24.0
Header resize and hide/show has no bugs.
header.open.close.mov