Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce composer-unused check #682

Open
wants to merge 1 commit into
base: 1.12
Choose a base branch
from

Conversation

mmenozzi
Copy link
Contributor

No description provided.

@mmenozzi mmenozzi requested a review from a team as a code owner February 27, 2022 16:25
@vvasiloi vvasiloi self-assigned this Feb 28, 2022
@lchrusciel
Copy link
Member

Hey @mmenozzi - can we exclude flex from the check?

@mmenozzi
Copy link
Contributor Author

mmenozzi commented Aug 4, 2022

Hi @lchrusciel, sorry for my late reply...
symfony/flex is already ignored (see here) indeed the build is not failing. But it appears that the github output mode puts a warning annotation on the symfony/flex package anyway.

This is the raw output using the default mode and the github mode:

Schermata 2022-08-04 alle 08 02 01

If you prefer I can switch to the default output but we'll loose error annotations in the CI summary, like this:

Schermata 2022-08-04 alle 08 04 35

Maybe it's better to loose errors in CI summary instead of having a warning for symfony/flex for every build...

Or maybe we can do this "hack" to exclude warnings from the github output:

php composer-unused.phar -o github | grep -v "::warning"

Let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants