Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended ObjectSerializer uses registered GuidSerializer.GuidRepresentation #100

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

nscheibe
Copy link
Member

If we register the GuidSerializer with the choosen GuidRepresentation (Standard, CSharpLegacy, JavaLegacy etc.), then the ObjectSerializer gets this GuidRepresentation not by default. The ObjectSerializer still throws the exception, that the GuidSerializer is not registered (or unknown). This extension adds the GuidRepresentation of the registered GuidSerializer to the ObjectSerializer as default.

@nscheibe nscheibe changed the title Extended ObjectSerializer uses default GuidSerializer GuidRepresentation Extended ObjectSerializer uses registered GuidSerializer GuidRepresentation Jan 30, 2025
@nscheibe nscheibe changed the title Extended ObjectSerializer uses registered GuidSerializer GuidRepresentation Extended ObjectSerializer uses registered GuidSerializer.GuidRepresentation Jan 30, 2025
Copy link
Contributor

@Carael Carael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good:) Ship it 🚀

@nscheibe
Copy link
Member Author

I will ! :)

@nscheibe nscheibe merged commit 77cd3b4 into master Jan 30, 2025
2 checks passed
@nscheibe nscheibe deleted the guidSerializerIssue branch January 30, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants