add test to print nested json #806
Conversation
| } | ||
|
|
||
| func testJson() { | ||
| let dictionary = ["1":2,"2":2,"three":3,"list":["aa","bb","dd"], "foo": []] as NSDictionary |
There was a problem hiding this comment.
nitpick: this dictionary should format with a trailing space after :, just like line 135.
| @@ -120,5 +120,28 @@ class PrintableTests: XCTestCase { | |||
| XCTAssertTrue(description.range(of: "\"1\":2", options: NSString.CompareOptions.caseInsensitive) != nil) | |||
| XCTAssertTrue(description.range(of: "\"2\":\"two\"", options: NSString.CompareOptions.caseInsensitive) != nil) | |||
| XCTAssertTrue(description.range(of: "\"3\":null", options: NSString.CompareOptions.caseInsensitive) != nil) | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| description2 = description2.replacingOccurrences(of: "\n", with: "") | ||
| description2 = description2.replacingOccurrences(of: " ", with: "") | ||
| XCTAssertTrue(description2.range(of: "\"json\":{", options: NSString.CompareOptions.caseInsensitive) != nil) | ||
| XCTAssertTrue(description2.range(of: description, options: NSString.CompareOptions.caseInsensitive) != nil) |
There was a problem hiding this comment.
Line Length Violation: Line should be 100 characters or less: currently 109 characters (line_length)
| } | ||
| description2 = description2.replacingOccurrences(of: "\n", with: "") | ||
| description2 = description2.replacingOccurrences(of: " ", with: "") | ||
| XCTAssertTrue(description2.range(of: "\"json\":{", options: NSString.CompareOptions.caseInsensitive) != nil) |
There was a problem hiding this comment.
Line Length Violation: Line should be 100 characters or less: currently 110 characters (line_length)
| } | ||
|
|
||
| func testJson() { | ||
| let dictionary = ["1": 2,"2": 2,"three": 3,"list": ["aa", "bb", "dd"], "foo": []] as NSDictionary |
There was a problem hiding this comment.
Comma Spacing Violation: There should be no space before and one after any comma. (comma)
| } | ||
|
|
||
| func testJson() { | ||
| let dictionary = ["1": 2,"2": 2,"three": 3,"list": ["aa", "bb", "dd"], "foo": []] as NSDictionary |
There was a problem hiding this comment.
Comma Spacing Violation: There should be no space before and one after any comma. (comma)
|
Hey @gsabran Seems like the format is broken, would you mind fixing it? Or I will do it by myself. |
Just adding a test to make sure nested JSON gets printed correctly (which they do) that was in #801