Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues in ModelsTrainer and SpeakerIdentifier #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

manitbaser
Copy link

…se of SilenceEliminator; Achieved an accuracy of 98.132%

…se of SilenceEliminator; Achieved an accuracy of 98.132%
Copy link
Owner

@SuperKogito SuperKogito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank your for the PR. The changes made are valuable, especially the import edits.
However, the silence eliminator should be kept, as it is vital in such applications. The reason you use a VAD or here called a silence eliminator is because you want to base your model/ predictions on voice only data. Otherwise the model will take into account the "silent" noise of the speaker surroundings. Which could result in the following: If the recordings have similar "silent" noise then the prediction will be improved but in case the user speaks in a different setup resulting in a different surrounding noise/ silent noise then the prediction would not be accurate as the system will consider the silence instances as different to the ones the model is trained on. So in conclusion, removing the silence eliminator might improve the accuracy in some cases, but overall it will degrade the robustness of the system.

Code/ModelsTrainer.py Outdated Show resolved Hide resolved
@manitbaser
Copy link
Author

Hi, fixed the errors in SilenceEliminator and added it as discussed previously. SilenceEliminator wasn't running due to some bugs, so modified the file a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants