Get top and similar tracks #219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns the search results controller into a generic "we have a list of tracks" controller. It should probably be renamed, along with the class and enum that holds the tracks to begin with. There's some hacks to make this work with an ObjC frontend. Once we convert it to Swift, we can just expose the enum directly. UI is not wired up yet.
There's an issue with titles that kind of sucks. Will have to fix. Fixes GH-109
Could have used bindings instead, don't feel too strongly either way
|
@SevereOverfl0w Sorry your feature requests came late. If you (want to) try this, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does some refactoring to the search controller and results class to handle the concept of not just searches, but other lists of tracks returned by the server. It's a little gross at times because it has to interface Swift's enums with the Objective-C side. I'm not sure if this is the best strategy, but it does seem to work for now; we can split out the new stuff into a separate controller if needed..
Note that the "quality" of the returned tracks is highly dependent on server configuration; Subsonic and Navidrome at least rely on last.fm for anything more intelligent than returning starred tracks.
Fixes GH-108 and GH-109.