Update Kotlin scope#106
Draft
guille wants to merge 1 commit intoSublimeText:developfrom
Draft
Conversation
There is a proposal to move the Kotlin package, which would include changing the scope name to a more standard `source.kotlin`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have a PR in PC to change ownership of package for Kotlin. It does have a breaking change, since the scope changes from
source.Kotlintosource.kotlin. I've tried to support both in all places, the one exception isfile_type_kotlin_gradle, as I don't think more than one base scope is supported. I've tentatively put the new scope name only, meaning this should not be merged until the Kotlin package has changed.Motivation and Context
See above
How Has This Been Tested?
It hasn't
Types of changes
Checklist: