Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict regex for matching function signatures #457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brandonchinn178
Copy link
Contributor

Before:
Screen Shot 2022-11-03 at 5 33 08 PM
After:
Screen Shot 2022-11-03 at 5 33 24 PM

Notice how in the before, invalid function names (like those starting with an apostrophe or with an upper case letter) were matched. But more urgently, it erroneously matched inline type annotations using ScopedTypeVariables.

Now, we restrict the regex to only allow functions to start with a lowercase letter or underscore. Notice that now, the ScopedTypeVariables syntax now less wrong (it still doesn't highlight the RHS as a Type, but at least it doesn't mess up the whole line)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant