Restrict regex for matching function signatures #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Notice how in the before, invalid function names (like those starting with an apostrophe or with an upper case letter) were matched. But more urgently, it erroneously matched inline type annotations using ScopedTypeVariables.
Now, we restrict the regex to only allow functions to start with a lowercase letter or underscore. Notice that now, the ScopedTypeVariables syntax now less wrong (it still doesn't highlight the RHS as a Type, but at least it doesn't mess up the whole line)