Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: rewrite to typescript #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP: rewrite to typescript #36

wants to merge 3 commits into from

Conversation

dartess
Copy link

@dartess dartess commented Aug 9, 2021

#34

what was done:

  • code rewritten to typescript
  • the assembly remained on browserify, because the umd generation works, and the concatenation of the license file also works, and there is also no point in rewriting the ie file.
  • types are generated separately because tsify cannot do this

what are the questions:

  • is everything okay?

  • jshit doesn't work with typescript. I have a few options:
    a) just remove jshit
    b) convert jshit config to eslint. at the same time, a lot of settings that go by default will be missed (only those rules that are explicitly indicated in the config will remain)
    c) connect any standard preset for eslint, for example airbnb or your favorite.

  • should i increase the version? Minor or patch?

  • can I add myself to the package contributors?

@vtrphan
Copy link

vtrphan commented Oct 27, 2022

what's the status of this? i really need TS definitions. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants