Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.4 #25

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Laravel 5.4 #25

wants to merge 25 commits into from

Conversation

jpuck
Copy link

@jpuck jpuck commented Feb 7, 2017

If you merge this into master, then you should bump the major version (2.0) to comply with semver because there were quite a few breaking changes that came about with 5.3 and 5.4.

Just to get started, service providers are initialized with a different method now 3366b33

With the introduction of the built-in web and api middleware routes, the session variable is only attached to the web routes (conversely api routes use tokens), so that needed to be loaded differently in 275b9ba in order for a user to stay logged in for subsequent requests.

Fixed the jwt-auth dependencies #24, including bootstrapping the aliases inside the service provider in 8a806bb

I wrote this to support multiple authentication types aside from just shib, and I noticed there was a bug when falling back to native authentication due to the type value not being set in 50fdb57

There have been some general namespacing conventions lately inside the config files, so I conformed the group_model and user model and revamped the documentation with Github-style markdown for syntax highlights.

@cjmaio
Copy link
Contributor

cjmaio commented Feb 13, 2017

Thank you for this commit! It's really appreciated. I am going to try and test this out within the next day or so, but assuming all goes well I'll be merging this in.

@jpuck
Copy link
Author

jpuck commented Feb 13, 2017

@jpuck jpuck mentioned this pull request Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants