-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 5.4 #25
Open
jpuck
wants to merge
25
commits into
StudentAffairsUWM:master
Choose a base branch
from
uawcob:lara5.4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Laravel 5.4 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use alias loader
This was referenced Feb 10, 2017
Thank you for this commit! It's really appreciated. I am going to try and test this out within the next day or so, but assuming all goes well I'll be merging this in. |
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you merge this into master, then you should bump the major version (2.0) to comply with semver because there were quite a few breaking changes that came about with 5.3 and 5.4.
Just to get started, service providers are initialized with a different method now 3366b33
With the introduction of the built-in web and api middleware routes, the session variable is only attached to the web routes (conversely api routes use tokens), so that needed to be loaded differently in 275b9ba in order for a user to stay logged in for subsequent requests.
Fixed the jwt-auth dependencies #24, including bootstrapping the aliases inside the service provider in 8a806bb
I wrote this to support multiple authentication types aside from just shib, and I noticed there was a bug when falling back to native authentication due to the
type
value not being set in 50fdb57There have been some general namespacing conventions lately inside the config files, so I conformed the
group_model
and usermodel
and revamped the documentation with Github-style markdown for syntax highlights.